Page 1 of 1

24 hour early active event calendar module

Posted: 4. December 2012 19:46
by shadzy89
Your Portal Version: 2.0.1
Your phpBB Type: Standard phpBB3
MODs installed: Yes
Your knowledge: Basic Knowledge
Boardlink: http://eff-clan.org

What have you done before the problem was there?
Updated Board 3 to latest version: 2.0.1

What have you already tryed to solve the problem?
Nothing

Description and Message
Hi guys,

It seems to show the event on the calendar 1 day earlier than set, and it leaves it on there until expiry time of the event a full 24 hours later.

Help?

Re: 24 hour early active event calendar module

Posted: 4. December 2012 23:07
by Marc
It's not shown as active even but rather as current event. The exact times can be seen in the events part of the calendar. This is expected behavior.

Re: 24 hour early active event calendar module

Posted: 6. December 2012 00:26
by shadzy89
but i had an event on 5th dec, it came active on the 4th??

Re: 24 hour early active event calendar module

Posted: 6. December 2012 00:35
by Marc
It doesn't show as active. It shows as current. Any event in the next 24 hours will show as current. It still displays the time so I really don't see your problem here. :?

Re: 24 hour early active event calendar module

Posted: 8. December 2012 07:16
by shadzy89
Matter of quick flash. If they see current event, they come on server. Little do they realise that it is meant for another time.

What was changed since 2.0.1 for this particular setting so im ay revert it back to only show as current within the given time frame?

Re: 24 hour early active event calendar module

Posted: 8. December 2012 11:02
by Marc
The behavior was changed in this commit:
https://github.com/board3/Board3-Portal ... 1fe95cd246

Re: 24 hour early active event calendar module

Posted: 8. December 2012 17:25
by shadzy89
wow i see ok thanks

I gotta get my thinking hat on.

Am I right in assuming that there r multiple things to change in here?>

Re: 24 hour early active event calendar module

Posted: 8. December 2012 18:40
by Marc
That part is the actual change that you would need to revert:
https://github.com/board3/Board3-Portal ... 246#L0L210

Re: 24 hour early active event calendar module

Posted: 9. December 2012 20:22
by shadzy89
From 210-213??

Re: 24 hour early active event calendar module

Posted: 9. December 2012 22:02
by Marc
Yes, that code is replace with the text with green background right below that. ;)

Re: 24 hour early active event calendar module

Posted: 13. December 2012 23:46
by shadzy89
with that modification done, it shows up 1 hour earlier, but this is much better than before.

Thanks Marc for your help!!! :)